[Enhancement] 不在主界面，或者已显示对话框的情况下，暂时不弹出启动器更新对话框#6095
Conversation
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/main/MainPage.java
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/main/MainPage.java
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/main/MainPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/main/MainPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/main/RootPage.java
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to queue and display dialogs sequentially ("showLater" / "dialogLater") to prevent overlapping dialogs, particularly for the update dialog on the main page. It also refactors the binding of update properties and adjusts the execution order in "UpdateChecker". The feedback suggests extracting "getRootPage().getMainPage()" into a local variable in "Controllers.java" to improve readability and avoid redundant method calls.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
这个PR似乎也很好了 CC @Glavo |
3 participants
Closes #5762
Fixes #5490
如果不在主界面，则会在切换回主界面之后再显示；如果已经有对话框，则在对话框关闭后再显示